return true;
// Check whether we implicitly construct a class from a
// std::initializer_list.
- if (const auto *ImplicitCE = dyn_cast<CXXConstructExpr>(Arg)) {
- if (ImplicitCE->isStdInitListInitialization())
+ if (const auto *CEArg = dyn_cast<CXXConstructExpr>(Arg)) {
+ // Strip the elidable move constructor, it is present in the AST for
+ // C++11/14, e.g. Foo(Bar{1, 2}), the move constructor is around the
+ // init-list constructor.
+ if (CEArg->isElidable()) {
+ if (const auto *TempExp = CEArg->getArg(0)) {
+ if (const auto *UnwrappedCE =
+ dyn_cast<CXXConstructExpr>(TempExp->IgnoreImplicit()))
+ CEArg = UnwrappedCE;
+ }
+ }
+ if (CEArg->isStdInitListInitialization())
return true;
}
- return false;
}
return false;
};
-// RUN: %check_clang_tidy -std=c++14 %s modernize-make-unique %t -- -- -I %S/Inputs/modernize-smart-ptr
-// FIXME: Fix the checker to work in C++17 mode.
+// RUN: %check_clang_tidy -std=c++14,c++17 %s modernize-make-unique %t -- -- -I %S/Inputs/modernize-smart-ptr
+// FIXME: Fix the test code in C++2a mode.
#include "unique_ptr.h"
#include "initializer_list.h"
std::unique_ptr<J> PJ2 = std::unique_ptr<J>(new J(E{1, 2}, 1));
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
- // CHECK-FIXES: std::unique_ptr<J> PJ2 = std::make_unique<J>(E{1, 2}, 1);
+ // CHECK-FIXES: std::unique_ptr<J> PJ2 = std::unique_ptr<J>(new J(E{1, 2}, 1));
PJ2.reset(new J(E{1, 2}, 1));
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead
- // CHECK-FIXES: PJ2 = std::make_unique<J>(E{1, 2}, 1);
+ // CHECK-FIXES: PJ2.reset(new J(E{1, 2}, 1));
std::unique_ptr<J> PJ3 = std::unique_ptr<J>(new J{ {1, 2}, 1 });
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
std::unique_ptr<J> PJ4 = std::unique_ptr<J>(new J{E{1, 2}, 1});
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
- // CHECK-FIXES: std::unique_ptr<J> PJ4 = std::make_unique<J>(E{1, 2}, 1);
+ // CHECK-FIXES: std::unique_ptr<J> PJ4 = std::unique_ptr<J>(new J{E{1, 2}, 1});
PJ4.reset(new J{E{1, 2}, 1});
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead
- // CHECK-FIXES: PJ4 = std::make_unique<J>(E{1, 2}, 1);
+ // CHECK-FIXES: PJ4.reset(new J{E{1, 2}, 1});
std::unique_ptr<Foo> FF = std::unique_ptr<Foo>(new Foo());
// CHECK-MESSAGES: :[[@LINE-1]]:29: warning: