dmaengine: at_hdmac: In atc_prep_dma_memset, treat value as a single byte
authorBen Walker <benjamin.walker@intel.com>
Tue, 1 Mar 2022 18:25:49 +0000 (11:25 -0700)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Apr 2022 11:58:12 +0000 (17:28 +0530)
The value passed in to .prep_dma_memset is to be treated as a single
byte repeating pattern.

Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20220301182551.883474-3-benjamin.walker@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_hdmac.c

index 30ae361..5a50423 100644 (file)
@@ -942,6 +942,7 @@ atc_prep_dma_memset(struct dma_chan *chan, dma_addr_t dest, int value,
        struct at_desc          *desc;
        void __iomem            *vaddr;
        dma_addr_t              paddr;
+       char                    fill_pattern;
 
        dev_vdbg(chan2dev(chan), "%s: d%pad v0x%x l0x%zx f0x%lx\n", __func__,
                &dest, value, len, flags);
@@ -963,7 +964,14 @@ atc_prep_dma_memset(struct dma_chan *chan, dma_addr_t dest, int value,
                        __func__);
                return NULL;
        }
-       *(u32*)vaddr = value;
+
+       /* Only the first byte of value is to be used according to dmaengine */
+       fill_pattern = (char)value;
+
+       *(u32*)vaddr = (fill_pattern << 24) |
+                      (fill_pattern << 16) |
+                      (fill_pattern << 8) |
+                      fill_pattern;
 
        desc = atc_create_memset_desc(chan, paddr, dest, len);
        if (!desc) {