ALSA: firewire-motu: fix error return code in snd_motu_stream_reserve_duplex()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 3 Jun 2021 14:32:03 +0000 (22:32 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 4 Jun 2021 06:47:53 +0000 (08:47 +0200)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: e50dfac81f73 ("ALSA: firewire-motu: cache event ticks in source packet header per data block")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210603143203.582017-1-yangyingliang@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/motu/motu-stream.c

index 43ff5be..9e6ca39 100644 (file)
@@ -191,7 +191,7 @@ int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate,
                if (!motu->cache.event_offsets) {
                        fw_iso_resources_free(&motu->tx_resources);
                        fw_iso_resources_free(&motu->rx_resources);
-                       return err;
+                       return -ENOMEM;
                }
        }