projects
/
platform
/
upstream
/
libnice.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f08083c
)
socket: Add note that the packet dropping in tcp-bsd is broken behavior
author
Olivier Crête
<olivier.crete@collabora.com>
Fri, 24 Jan 2014 08:02:38 +0000
(
03:02
-0500)
committer
Olivier Crête
<olivier.crete@collabora.com>
Fri, 31 Jan 2014 06:49:07 +0000
(
01:49
-0500)
socket/tcp-bsd.c
patch
|
blob
|
history
diff --git
a/socket/tcp-bsd.c
b/socket/tcp-bsd.c
index
6e54b22
..
5792129
100644
(file)
--- a/
socket/tcp-bsd.c
+++ b/
socket/tcp-bsd.c
@@
-285,6
+285,9
@@
socket_send_message (NiceSocket *sock, const NiceOutputMessage *message)
ret = message->length;
}
} else {
+ /* FIXME: This dropping will break http/socks5/etc
+ * We probably need a way to the upper layer to control reliability
+ */
/* If the queue is too long, drop whatever packets we can. */
if (g_queue_get_length (&priv->send_queue) >= MAX_QUEUE_LENGTH) {
guint peek_idx = 0;