mac80211: enable power save only if DTIM period is available
authorAlexander Bondar <alexander.bondar@intel.com>
Mon, 6 May 2013 14:17:04 +0000 (17:17 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 16 May 2013 21:01:29 +0000 (23:01 +0200)
Generally, the DTIM period is available after a beacon has
been received, and if no beacon has been received enabling
powersave is problematic anyway for synchronisation. Since
some drivers may require the DTIM period for powersave,
don't enable powersave until it becomes available in case
the scan/association managed to not receive a beacon.

Signed-off-by: Alexander Bondar <alexander.bondar@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c

index a8016c0..ef378b9 100644 (file)
@@ -1390,6 +1390,9 @@ static bool ieee80211_powersave_allowed(struct ieee80211_sub_if_data *sdata)
                          IEEE80211_STA_CONNECTION_POLL))
                return false;
 
+       if (!sdata->vif.bss_conf.dtim_period)
+               return false;
+
        rcu_read_lock();
        sta = sta_info_get(sdata, mgd->bssid);
        if (sta)
@@ -3126,6 +3129,7 @@ ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
                }
 
                changed |= BSS_CHANGED_DTIM_PERIOD;
+               ieee80211_recalc_ps_vif(sdata);
        }
 
        if (elems.erp_info) {