drm/amdgpu: Remove else after return in 'is_fru_eeprom_supported'
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Sun, 23 Jul 2023 06:34:13 +0000 (12:04 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 25 Jul 2023 17:47:26 +0000 (13:47 -0400)
Expressions under 'else' branch under case 'CHIP_SIENNA_CICHLID' in
function 'is_fru_eeprom_supported' are executed whenever the expression
in 'if' is False. Otherwise, return from case occurs. Therefore, there
is no need in 'else', and it has been removed.

Fixes the following:

WARNING: else is not generally useful after a break or return
+                               return false;
+                       } else {

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c

index c9f16ea..8c3ee04 100644 (file)
@@ -83,11 +83,12 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev, u32 *fru_addr)
                        if (strnstr(atom_ctx->vbios_pn, "D603GLXE",
                                    sizeof(atom_ctx->vbios_pn))) {
                                return false;
-                       } else {
-                               if (fru_addr)
-                                       *fru_addr = FRU_EEPROM_MADDR_6;
-                               return true;
                        }
+
+                       if (fru_addr)
+                               *fru_addr = FRU_EEPROM_MADDR_6;
+                       return true;
+
                } else {
                        return false;
                }