platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Tue, 12 Jul 2022 21:45:54 +0000 (17:45 -0400)
committerPrashant Malani <pmalani@chromium.org>
Wed, 13 Jul 2022 17:28:17 +0000 (17:28 +0000)
The typec_register_port() can fail with EPROBE_DEFER if the endpoint
node hasn't probed yet. In order to avoid spamming the log with errors
in that case, log using dev_err_probe().

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220712214554.545035-1-nfraprado@collabora.com
Signed-off-by: Prashant Malani <pmalani@chromium.org>
drivers/platform/chrome/cros_ec_typec.c

index d6088ba..8c0ca3c 100644 (file)
@@ -352,8 +352,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
 
                cros_port->port = typec_register_port(dev, cap);
                if (IS_ERR(cros_port->port)) {
-                       dev_err(dev, "Failed to register port %d\n", port_num);
                        ret = PTR_ERR(cros_port->port);
+                       dev_err_probe(dev, ret, "Failed to register port %d\n", port_num);
                        goto unregister_ports;
                }