Bail in bounds_of_var_in_loop if scev returns NULL.
authorAldy Hernandez <aldyh@redhat.com>
Thu, 13 May 2021 20:09:58 +0000 (16:09 -0400)
committerAldy Hernandez <aldyh@redhat.com>
Mon, 17 May 2021 16:18:37 +0000 (18:18 +0200)
Both initial_condition_in_loop_num and evolution_part_in_loop_num
can return NULL.  This patch exits if either one is NULL.  Presumably
this didn't happen before, because adjust_range_with_scev was called
far less frequently than in ranger, which can call it for every PHI.

gcc/ChangeLog:

PR tree-optimization/100349
* vr-values.c (bounds_of_var_in_loop): Bail if scev returns
  NULL.

gcc/testsuite/ChangeLog:

* gcc.dg/pr100349.c: New test.

gcc/testsuite/gcc.dg/pr100349.c [new file with mode: 0644]
gcc/vr-values.c

diff --git a/gcc/testsuite/gcc.dg/pr100349.c b/gcc/testsuite/gcc.dg/pr100349.c
new file mode 100644 (file)
index 0000000..dd7977a
--- /dev/null
@@ -0,0 +1,16 @@
+// { dg-do compile }
+// { dg-options "-O2 -w" }
+
+#include <stdint.h>
+uint8_t a;
+b(int8_t c) {
+  int d;
+e:
+  uint32_t f;
+  for (;;)
+    for (c = 10; c; c++)
+      if (0 > (a = c) ?: d) {
+        f = a;
+        goto e;
+      }
+}
index 08b237b..b1bf53a 100644 (file)
@@ -1650,6 +1650,9 @@ bounds_of_var_in_loop (tree *min, tree *max, range_query *query,
   init = initial_condition_in_loop_num (chrec, loop->num);
   step = evolution_part_in_loop_num (chrec, loop->num);
 
+  if (!init || !step)
+    return false;
+
   /* If INIT is an SSA with a singleton range, set INIT to said
      singleton, otherwise leave INIT alone.  */
   if (TREE_CODE (init) == SSA_NAME)