ath6kl: fix enum-conversion warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 26 Oct 2020 21:29:56 +0000 (22:29 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 7 Nov 2020 08:08:33 +0000 (10:08 +0200)
gcc -Wextra points out a type mismatch

drivers/net/wireless/ath/ath6kl/wmi.c: In function 'ath6kl_wmi_cmd_send':
drivers/net/wireless/ath/ath6kl/wmi.c:1825:19: warning: implicit conversion from 'enum <anonymous>' to 'enum wmi_data_hdr_data_type' [-Wenum-conversion]
 1825 |            false, false, 0, NULL, if_idx);
      |                   ^~~~~

As far as I can tell, the numeric value is current here,
so just use the correct enum literal instead of 'false'.

Fixes: bdcd81707973 ("Add ath6kl cleaned up driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201026213040.3889546-9-arnd@kernel.org
drivers/net/wireless/ath/ath6kl/wmi.c

index dbc4770..b137e7f 100644 (file)
@@ -1821,8 +1821,8 @@ int ath6kl_wmi_cmd_send(struct wmi *wmi, u8 if_idx, struct sk_buff *skb,
 
        /* Only for OPT_TX_CMD, use BE endpoint. */
        if (cmd_id == WMI_OPT_TX_FRAME_CMDID) {
-               ret = ath6kl_wmi_data_hdr_add(wmi, skb, OPT_MSGTYPE,
-                                             false, false, 0, NULL, if_idx);
+               ret = ath6kl_wmi_data_hdr_add(wmi, skb, OPT_MSGTYPE, false,
+                               WMI_DATA_HDR_DATA_TYPE_802_3, 0, NULL, if_idx);
                if (ret) {
                        dev_kfree_skb(skb);
                        return ret;