staging: vt6656: Compress return logic into one line.
authorElise Lennion <elise.lennion@gmail.com>
Mon, 17 Oct 2016 02:18:58 +0000 (00:18 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Oct 2016 08:27:55 +0000 (10:27 +0200)
Compress the return logic into one line avoids unnecessary variable
declarations. In this case it also makes it easier to understand the
function.

Coccinelle was used to find this return statement. However, additional
compressions were done to make the function clearer.

Semantic patch:
@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/card.c

index 807d3f7..0e5a993 100644 (file)
@@ -501,16 +501,7 @@ u8 vnt_get_pkt_type(struct vnt_private *priv)
  */
 u64 vnt_get_tsf_offset(u8 rx_rate, u64 tsf1, u64 tsf2)
 {
-       u64 tsf_offset = 0;
-       u16 rx_bcn_offset;
-
-       rx_bcn_offset = cw_rxbcntsf_off[rx_rate % MAX_RATE];
-
-       tsf2 += (u64)rx_bcn_offset;
-
-       tsf_offset = tsf1 - tsf2;
-
-       return tsf_offset;
+       return tsf1 - tsf2 - (u64)cw_rxbcntsf_off[rx_rate % MAX_RATE];
 }
 
 /*