drm: rcar-du: Only initialise TVM_TVSYNC mode when supported
authorKieran Bingham <kieran.bingham@ideasonboard.com>
Wed, 22 Sep 2021 23:47:23 +0000 (00:47 +0100)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thu, 7 Oct 2021 02:59:48 +0000 (05:59 +0300)
The R-Car DU as found on the D3, E3, and V3U do not have support
for an external synchronisation method.

In these cases, the dsysr cached register should not be initialised
in DSYSR_TVM_TVSYNC, but instead should be left clear to configure as
DSYSR_TVM_MASTER by default.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
drivers/gpu/drm/rcar-du/rcar_du_crtc.c

index ea7e39d..a0f837e 100644 (file)
@@ -1243,7 +1243,10 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex,
        rcrtc->group = rgrp;
        rcrtc->mmio_offset = mmio_offsets[hwindex];
        rcrtc->index = hwindex;
-       rcrtc->dsysr = (rcrtc->index % 2 ? 0 : DSYSR_DRES) | DSYSR_TVM_TVSYNC;
+       rcrtc->dsysr = rcrtc->index % 2 ? 0 : DSYSR_DRES;
+
+       if (rcar_du_has(rcdu, RCAR_DU_FEATURE_TVM_SYNC))
+               rcrtc->dsysr |= DSYSR_TVM_TVSYNC;
 
        if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE))
                primary = &rcrtc->vsp->planes[rcrtc->vsp_pipe].plane;