[media] staging/media: Use dev_ printks in lirc/igorplugusb.c
authorYAMANE Toshiaki <yamanetoshi@gmail.com>
Thu, 8 Nov 2012 18:53:53 +0000 (15:53 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 21 Dec 2012 21:15:51 +0000 (19:15 -0200)
fixed below checkpatch warnings.
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/staging/media/lirc/lirc_igorplugusb.c

index 939a801..2faa391 100644 (file)
@@ -223,8 +223,8 @@ static int unregister_from_lirc(struct igorplug *ir)
        int devnum;
 
        if (!ir) {
-               printk(KERN_ERR "%s: called with NULL device struct!\n",
-                      __func__);
+               dev_err(&ir->usbdev->dev,
+                       "%s: called with NULL device struct!\n", __func__);
                return -EINVAL;
        }
 
@@ -232,8 +232,8 @@ static int unregister_from_lirc(struct igorplug *ir)
        d = ir->d;
 
        if (!d) {
-               printk(KERN_ERR "%s: called with NULL lirc driver struct!\n",
-                      __func__);
+               dev_err(&ir->usbdev->dev,
+                       "%s: called with NULL lirc driver struct!\n", __func__);
                return -EINVAL;
        }
 
@@ -347,8 +347,8 @@ static int igorplugusb_remote_poll(void *data, struct lirc_buffer *buf)
                if (ir->buf_in[2] == 0)
                        send_fragment(ir, buf, DEVICE_HEADERLEN, ret);
                else {
-                       printk(KERN_WARNING DRIVER_NAME
-                              "[%d]: Device buffer overrun.\n", ir->devnum);
+                       dev_warn(&ir->usbdev->dev,
+                                "[%d]: Device buffer overrun.\n", ir->devnum);
                        /* HHHNNNNNNNNNNNOOOOOOOO H = header
                              <---[2]--->         N = newer
                           <---------ret--------> O = older */