ide: don't disable interrupts during kmap_atomic()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Fri, 4 May 2018 14:24:45 +0000 (16:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Jun 2018 20:26:47 +0000 (16:26 -0400)
ide_pio_bytes() disables interrupts around kmap_atomic(). This is a
leftover from the old kmap_atomic() implementation which relied on fixed
mapping slots, so the caller had to make sure that the same slot could not
be reused from an interrupting context.

kmap_atomic() was changed to dynamic slots long ago and commit 1ec9c5ddc17a
("include/linux/highmem.h: remove the second argument of k[un]map_atomic()")
removed the slot assignements, but the callers were not checked for now
redundant interrupt disabling.

Remove the conditional interrupt disable.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-taskfile.c

index c034cd9..14bdab1 100644 (file)
@@ -237,7 +237,6 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
 
        while (len) {
                unsigned nr_bytes = min(len, cursg->length - cmd->cursg_ofs);
-               int page_is_high;
 
                page = sg_page(cursg);
                offset = cursg->offset + cmd->cursg_ofs;
@@ -248,10 +247,6 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
 
                nr_bytes = min_t(unsigned, nr_bytes, (PAGE_SIZE - offset));
 
-               page_is_high = PageHighMem(page);
-               if (page_is_high)
-                       local_irq_save(flags);
-
                buf = kmap_atomic(page) + offset;
 
                cmd->nleft -= nr_bytes;
@@ -270,9 +265,6 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
 
                kunmap_atomic(buf);
 
-               if (page_is_high)
-                       local_irq_restore(flags);
-
                len -= nr_bytes;
        }
 }