drm/komeda: remove redundant assignment to pointer disable_done
authorColin Ian King <colin.king@canonical.com>
Fri, 4 Oct 2019 16:21:56 +0000 (17:21 +0100)
committerjames qian wang (Arm Technology China) <james.qian.wang@arm.com>
Wed, 9 Oct 2019 08:07:06 +0000 (16:07 +0800)
The pointer disable_done is being initialized with a value that
is never read and is being re-assigned a little later on. The
assignment is redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004162156.325-1-colin.king@canonical.com
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c

index 75263d8..9beeda0 100644 (file)
@@ -296,7 +296,7 @@ komeda_crtc_atomic_disable(struct drm_crtc *crtc,
        struct komeda_crtc_state *old_st = to_kcrtc_st(old);
        struct komeda_pipeline *master = kcrtc->master;
        struct komeda_pipeline *slave  = kcrtc->slave;
-       struct completion *disable_done = &crtc->state->commit->flip_done;
+       struct completion *disable_done;
        bool needs_phase2 = false;
 
        DRM_DEBUG_ATOMIC("CRTC%d_DISABLE: active_pipes: 0x%x, affected: 0x%x\n",