subtitleoverlay: fix mutex error if sink caps is not video
authorGuillaume Desmottes <guillaume.desmottes@onestream.live>
Tue, 4 Jul 2023 13:37:16 +0000 (15:37 +0200)
committerTim-Philipp Müller <tim@centricular.com>
Wed, 5 Jul 2023 12:20:34 +0000 (13:20 +0100)
We were trying to unlock a mutex that was not locked.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4972>

subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c

index f57cbd4..53189e5 100644 (file)
@@ -1735,7 +1735,6 @@ gst_subtitle_overlay_video_sink_setcaps (GstSubtitleOverlay * self,
   if (!gst_video_info_from_caps (&info, caps)) {
     GST_ERROR_OBJECT (self, "Failed to parse caps");
     ret = FALSE;
-    GST_SUBTITLE_OVERLAY_UNLOCK (self);
     goto out;
   }