pinctrl: bcm2835: Handle gpiochip_add_pin_range() errors
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 16 Apr 2023 21:43:41 +0000 (23:43 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 8 May 2023 13:42:24 +0000 (15:42 +0200)
gpiochip_add_pin_range() can fail, so better return its error code than
a hard coded '0'.

Fixes: d2b67744fd99 ("pinctrl: bcm2835: implement hook for missing gpio-ranges")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/98c3b5890bb72415145c9fe4e1d974711edae376.1681681402.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm2835.c

index 7435173..1489191 100644 (file)
@@ -376,10 +376,8 @@ static int bcm2835_add_pin_ranges_fallback(struct gpio_chip *gc)
        if (!pctldev)
                return 0;
 
-       gpiochip_add_pin_range(gc, pinctrl_dev_get_devname(pctldev), 0, 0,
-                              gc->ngpio);
-
-       return 0;
+       return gpiochip_add_pin_range(gc, pinctrl_dev_get_devname(pctldev), 0, 0,
+                                     gc->ngpio);
 }
 
 static const struct gpio_chip bcm2835_gpio_chip = {