staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:54 +0000 (20:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 24 Jul 2023 14:50:39 +0000 (16:50 +0200)
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-13-tzimmermann@suse.de
drivers/staging/fbtft/fbtft-core.c
drivers/staging/sm750fb/sm750.c

index 3a4abf3..eac1d57 100644 (file)
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
        info->var.transp.offset =  0;
        info->var.transp.length =  0;
 
-       info->flags =              FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
+       info->flags =              FBINFO_VIRTFB;
 
        par = info->par;
        par->info = info;
index c260f73..79bcd5b 100644 (file)
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
        info->screen_base = crtc->v_screen;
        pr_debug("screen_base vaddr = %p\n", info->screen_base);
        info->screen_size = line_length * var->yres_virtual;
-       info->flags = FBINFO_FLAG_DEFAULT | 0;
 
        /* set info->fix */
        fix->type = FB_TYPE_PACKED_PIXELS;