cifsd: add goto fail in asn1_oid_decode()

Add goto fail in asn1_oid_decode() to clean-up exception handling code.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifsd/asn1.c b/fs/cifsd/asn1.c
index aa6ea85..f2628dc 100644 (file)
--- a/fs/cifsd/asn1.c
+++ b/fs/cifsd/asn1.c
@@ -74,11 +74,8 @@ static bool asn1_oid_decode(const unsigned char *value, size_t vlen,
 
        optr = *oid;
 
-       if (!asn1_subid_decode(&iptr, end, &subid)) {
-               kfree(*oid);
-               *oid = NULL;
-               return false;
-       }
+       if (!asn1_subid_decode(&iptr, end, &subid))
+               goto fail;
 
        if (subid < 40) {
                optr[0] = 0;
@@ -95,19 +92,18 @@ static bool asn1_oid_decode(const unsigned char *value, size_t vlen,
        optr += 2;
 
        while (iptr < end) {
-               if (++(*oidlen) > vlen) {
-                       kfree(*oid);
-                       *oid = NULL;
-                       return false;
-               }
+               if (++(*oidlen) > vlen)
+                       goto fail;
 
-               if (!asn1_subid_decode(&iptr, end, optr++)) {
-                       kfree(*oid);
-                       *oid = NULL;
-                       return false;
-               }
+               if (!asn1_subid_decode(&iptr, end, optr++))
+                       goto fail;
        }
        return true;
+
+fail:
+       kfree(*oid);
+       *oid = NULL;
+       return false;
 }
 
 static bool