GetRequestType will return unknown if query_interface is not implemented

Change-Id: I46169a22d0f8c0ba71e30288ea3873f3bd664190
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>

diff --git a/src/common/pkgmgr_interface.cc b/src/common/pkgmgr_interface.cc
index 1e8d84940da8c3a8f1e9ffb624653adc41b671b7..10beec08559b17483a2c1e51eb0d7867e77c7c6f 100644 (file)
--- a/src/common/pkgmgr_interface.cc
+++ b/src/common/pkgmgr_interface.cc
@@ -84,12 +84,12 @@ PkgMgrInterface::~PkgMgrInterface() {
 }
 
 RequestType PkgMgrInterface::GetRequestType() const {
+  if (!query_interface_)
+    return RequestType::Unknown;
+
   if (!is_app_installed_) {
-    if (query_interface_)
-      is_app_installed_ =
-          query_interface_->IsPkgInstalled(GetRequestInfo(), GetUid());
-    else
-      is_app_installed_ = false;
+    is_app_installed_ =
+        query_interface_->IsPkgInstalled(GetRequestInfo(), GetUid());
   }
   switch (pkgmgr_installer_get_request_type(pi_)) {
     case PKGMGR_REQ_INSTALL : {
@@ -109,9 +109,7 @@ RequestType PkgMgrInterface::GetRequestType() const {
         if (extension == kDeltaFileExtension) {
           return RequestType::Delta;
         } else {
-          std::string pkgid = nullptr;
-          if (query_interface_)
-            pkgid = query_interface_->GetPkgId(GetRequestInfo());
+          std::string pkgid = query_interface_->GetPkgId(GetRequestInfo());
           if (!GetIsPreloadRequest() &&
               QueryIsReadonlyPackage(pkgid, GetUid()) &&
               !QueryIsUpdatedReadonlyPackage(pkgid, GetUid()))