net: hns3: refine the input parameter 'size' for snprintf()
authorGuojia Liao <liaoguojia@huawei.com>
Tue, 21 Jan 2020 08:42:09 +0000 (16:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jan 2020 10:46:21 +0000 (11:46 +0100)
The function snprintf() writes at most size bytes (including the
terminating null byte ('\0') to str. Now, We can guarantee that the
parameter of size is lager than the length of str to be formatting
including its terminating null byte. So it's unnecessary to minus 1
for the input parameter 'size'.

Signed-off-by: Guojia Liao <liaoguojia@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 06c58ed..6271b69 100644 (file)
@@ -4716,7 +4716,7 @@ static int __init hns3_init_module(void)
        pr_info("%s: %s\n", hns3_driver_name, hns3_copyright);
 
        client.type = HNAE3_CLIENT_KNIC;
-       snprintf(client.name, HNAE3_CLIENT_NAME_LENGTH - 1, "%s",
+       snprintf(client.name, HNAE3_CLIENT_NAME_LENGTH, "%s",
                 hns3_driver_name);
 
        client.ops = &client_ops;