iommu/vt-d: Remove unneeded validity check on dev
authorMuhammad Usama Anjum <usama.anjum@collabora.com>
Tue, 10 May 2022 02:34:00 +0000 (10:34 +0800)
committerJoerg Roedel <jroedel@suse.de>
Fri, 13 May 2022 13:14:56 +0000 (15:14 +0200)
dev_iommu_priv_get() is being used at the top of this function which
dereferences dev. Dev cannot be NULL after this. Remove the validity
check on dev and simplify the code.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/20220313150337.593650-1-usama.anjum@collabora.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20220510023407.2759143-2-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel/iommu.c

index efcecfa..b5caea9 100644 (file)
@@ -2501,7 +2501,7 @@ static struct dmar_domain *dmar_insert_one_dev_info(struct intel_iommu *iommu,
                }
        }
 
-       if (dev && domain_context_mapping(domain, dev)) {
+       if (domain_context_mapping(domain, dev)) {
                dev_err(dev, "Domain context map failed\n");
                dmar_remove_one_dev_info(dev);
                return NULL;