rtsp-server: Remove pointless assertions that can happen if client provides invalid...
authorSebastian Dröge <sebastian@centricular.com>
Thu, 24 Oct 2024 17:12:55 +0000 (20:12 +0300)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 25 Oct 2024 10:40:20 +0000 (10:40 +0000)
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3731
Fixes CVE-2024-44331

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7738>

subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c

index fa959fef3e20ca92a2ea5e4182e99677fdf7b300..0b303c94b44429b5ae552113cdf7dd729edd4cea 100644 (file)
@@ -2979,15 +2979,13 @@ gst_rtsp_media_get_rates (GstRTSPMedia * media, gdouble * rate,
           first_stream = FALSE;
         } else {
           if (save_rate != *rate || save_applied_rate != *applied_rate) {
-            /* diffrent rate or applied_rate, weird */
-            g_assert (FALSE);
+            /* different rate or applied_rate, weird */
             result = FALSE;
             break;
           }
         }
       } else {
-        /* complete stream withot rate and applied_rate, weird */
-        g_assert (FALSE);
+        /* complete stream without rate and applied_rate, weird */
         result = FALSE;
         break;
       }