sys/v4l2/v4l2src_calls.c: Don't overwrite our GValue with 0 but instead use the previ...

Original commit message from CVS:
* sys/v4l2/v4l2src_calls.c:
(gst_v4l2src_probe_caps_for_format_and_size):
Don't overwrite our GValue with 0 but instead use the previously
computed value. Fixes #471823 some more.

diff --git a/ChangeLog b/ChangeLog
index eb663c3..ffd4c9d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-09-07  Wim Taymans  <wim.taymans@gmail.com>
+
+       * sys/v4l2/v4l2src_calls.c:
+       (gst_v4l2src_probe_caps_for_format_and_size):
+       Don't overwrite our GValue with 0 but instead use the previously
+       computed value. Fixes #471823 some more.
+
 2007-09-06  Tim-Philipp Müller  <tim at centricular dot net>
 
        * docs/plugins/gst-plugins-good-plugins.hierarchy:
@@ -39,7 +46,7 @@
        Add some more debugging in the framerate function.
        Iterate stepwise framerate up to and _including_ the max and if nothing
        was added to the list, add a dummy 0/1 to 100/1 framerate so that we
-       don't end up with an empty list.
+       don't end up with an empty list. Fixes #471823
 
 2007-09-04  Wim Taymans  <wim.taymans@gmail.com>
 

diff --git a/sys/v4l2/v4l2src_calls.c b/sys/v4l2/v4l2src_calls.c
index b9d74a5..af57fab 100644 (file)
--- a/sys/v4l2/v4l2src_calls.c
+++ b/sys/v4l2/v4l2src_calls.c
@@ -535,9 +535,6 @@ gst_v4l2src_probe_caps_for_format_and_size (GstV4l2Src * v4l2src,
     gst_value_set_fraction (&max, num, denom);
 
     while (gst_value_compare (&frac, &max) <= 0) {
-      GValue frac = { 0, };
-      g_value_init (&frac, GST_TYPE_FRACTION);
-
       num = gst_value_get_fraction_numerator (&frac);
       denom = gst_value_get_fraction_denominator (&frac);
       GST_LOG_OBJECT (v4l2src, "adding stepwise framerate: %d/%d", denom, num);