sim: Be sure of calling freeargv() after successfully call buildargv().

Or there will be memory leak.

2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>

	* mcore/interp.c (sim_do_command): Call freeargv() before return.

diff --git a/sim/ChangeLog b/sim/ChangeLog
index 9ddee64..628e6a8 100644 (file)
--- a/sim/ChangeLog
+++ b/sim/ChangeLog
@@ -1,5 +1,9 @@
 2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>
 
+       * mcore/interp.c (sim_do_command): Call freeargv() before return.
+
+2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>
+
        * common/sim-options.c (sim_args_command): Call freeargv() when
        failure occurs.
 

diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c
index d2edd12..dfaa6aa 100644 (file)
--- a/sim/mcore/interp.c
+++ b/sim/mcore/interp.c
@@ -2143,6 +2143,7 @@ sim_do_command (sd, cmd)
          if ((simargv[1] == NULL) || (simargv[2] == NULL))
            {
              fprintf (stderr, "Error: missing argument to watch cmd.\n");
+             freeargv (simargv);
              return;
            }
          
@@ -2187,6 +2188,8 @@ sim_do_command (sd, cmd)
          fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n",
                   cmd);
        }
+
+      freeargv (simargv);
     }
   else
     {