libata debugging: Warn when unable to find timing descriptor based on xfer_mode
authorBorislav Petkov <bp@alien8.de>
Sun, 21 Oct 2012 16:57:56 +0000 (18:57 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Fri, 16 Nov 2012 04:51:11 +0000 (23:51 -0500)
ata_timing_find_mode could return NULL which is not checked by all
low-level ATA drivers using it and cause a NULL ptr deref. Warn at least
so that possible issues can get fixed easily.

Signed-off-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-core.c

index 3cc7096..f46fbd3 100644 (file)
@@ -2942,6 +2942,10 @@ const struct ata_timing *ata_timing_find_mode(u8 xfer_mode)
 
        if (xfer_mode == t->mode)
                return t;
+
+       WARN_ONCE(true, "%s: unable to find timing for xfer_mode 0x%x\n",
+                       __func__, xfer_mode);
+
        return NULL;
 }