ath9k: do not set half/quarter channel flags in AR_PHY_MODE
authorFelix Fietkau <nbd@openwrt.org>
Sat, 22 Feb 2014 13:52:48 +0000 (14:52 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 24 Feb 2014 20:38:38 +0000 (15:38 -0500)
5/10 MHz channel bandwidth is configured via the PLL clock, instead of
the AR_PHY_MODE register. Using that register is AR93xx specific, and
makes the mode incompatible with earlier chipsets.

In some early versions, these flags were apparently applied at the wrong
point in time and thus did not cause connectivity issues, however now
they are causing problems, as pointed out in this OpenWrt ticket:

https://dev.openwrt.org/ticket/14916

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/ar9003_phy.c

index 09facba..8927fc3 100644 (file)
@@ -868,10 +868,6 @@ static void ar9003_hw_set_rfmode(struct ath_hw *ah,
 
        if (IS_CHAN_A_FAST_CLOCK(ah, chan))
                rfMode |= (AR_PHY_MODE_DYNAMIC | AR_PHY_MODE_DYN_CCK_DISABLE);
-       if (IS_CHAN_QUARTER_RATE(chan))
-               rfMode |= AR_PHY_MODE_QUARTER;
-       if (IS_CHAN_HALF_RATE(chan))
-               rfMode |= AR_PHY_MODE_HALF;
 
        if (rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF))
                REG_RMW_FIELD(ah, AR_PHY_FRAME_CTL,