Fix coverity issue (Unchecked return value) 12/172512/3 accepted/tizen/unified/20180320.141240 submit/tizen/20180315.033609
authorGilbok Lee <gilbok.lee@samsung.com>
Wed, 14 Mar 2018 07:55:39 +0000 (16:55 +0900)
committerGilbok Lee <gilbok.lee@samsung.com>
Thu, 15 Mar 2018 02:37:25 +0000 (02:37 +0000)
If sound_manager_start_virtual_stream failed, radio doesn't need to
call sound_manager_stop_virtual_stream.

[Version] 0.2.34
[Profile] Mobile, Wearable
[Issue Type] Fix bugs

Change-Id: I279581f1c7b33483f04f3c6afd2c797ec0ed1aea

packaging/libmm-radio.spec
src/mm_radio_priv_hal.c

index f7e8b46..9072a22 100755 (executable)
@@ -1,6 +1,6 @@
 Name:       libmm-radio
 Summary:    Multimedia Framework Radio Library
-Version:    0.2.33
+Version:    0.2.34
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0
index 511c74b..1e7bb92 100755 (executable)
@@ -647,7 +647,7 @@ int _mmradio_start(mm_radio_t *radio)
        ret = sound_manager_start_virtual_stream(radio->vstream);
        if (ret) {
                MMRADIO_LOG_ERROR("failed to start sound manager virtual stream");
-               goto error;
+               goto error1;
        }
 #endif
 
@@ -657,10 +657,6 @@ int _mmradio_start(mm_radio_t *radio)
 
        return MM_ERROR_NONE;
 
-#ifdef TIZEN_FEATURE_SOUND_VSTREAM
-error:
-       sound_manager_stop_virtual_stream(radio->vstream);
-#endif
 error1:
        radio_hal_close(radio->hal_inf);
 error2: