scsi: lpfc: Fix memory leaks in error paths while issuing ELS RDF/SCR request

The ELS job request structure, that is allocated while issuing ELS RDF/SCR
request path, is not being released in an error path causing a memory leak
message on driver unload.

Free the ELS job structure in the error paths.

Link: https://lore.kernel.org/r/20210707184351.67872-10-jsmart2021@gmail.com
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index b1ca6f8..3381912 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3375,6 +3375,7 @@ lpfc_issue_els_scr(struct lpfc_vport *vport, uint8_t retry)
        if (phba->sli_rev == LPFC_SLI_REV4) {
                rc = lpfc_reg_fab_ctrl_node(vport, ndlp);
                if (rc) {
+                       lpfc_els_free_iocb(phba, elsiocb);
                        lpfc_printf_vlog(vport, KERN_ERR, LOG_NODE,
                                         "0937 %s: Failed to reg fc node, rc %d\n",
                                         __func__, rc);
@@ -3667,6 +3668,7 @@ lpfc_issue_els_rdf(struct lpfc_vport *vport, uint8_t retry)
 
        if (phba->sli_rev == LPFC_SLI_REV4 &&
            !(ndlp->nlp_flag & NLP_RPI_REGISTERED)) {
+               lpfc_els_free_iocb(phba, elsiocb);
                lpfc_printf_vlog(vport, KERN_ERR, LOG_NODE,
                                 "0939 %s: FC_NODE x%x RPI x%x flag x%x "
                                 "ste x%x type x%x Not registered\n",