RDMA/hns: Remove redundant assignment of wc->smac when polling cq
authorWeihang Li <liweihang@huawei.com>
Fri, 20 Mar 2020 03:23:41 +0000 (11:23 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Mar 2020 19:52:29 +0000 (16:52 -0300)
The field smac in ib_wc was used for create AH and then it will be treated
as destination mac address in UD sqwqe, but related code about filling smac
into AH has been removed in core. Actually, the dmac in UD sqwqe is parsed
from the dgid in grh which is passed in by ULP now, so this assignment
should be removed.

Link: https://lore.kernel.org/r/1584674622-52773-10-git-send-email-liweihang@huawei.com
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 2b03c72..31b6146 100644 (file)
@@ -3236,14 +3236,7 @@ static int hns_roce_v2_poll_one(struct hns_roce_cq *hr_cq,
                wc->port_num = roce_get_field(cqe->byte_32,
                                V2_CQE_BYTE_32_PORTN_M, V2_CQE_BYTE_32_PORTN_S);
                wc->pkey_index = 0;
-               memcpy(wc->smac, cqe->smac, 4);
-               wc->smac[4] = roce_get_field(cqe->byte_28,
-                                            V2_CQE_BYTE_28_SMAC_4_M,
-                                            V2_CQE_BYTE_28_SMAC_4_S);
-               wc->smac[5] = roce_get_field(cqe->byte_28,
-                                            V2_CQE_BYTE_28_SMAC_5_M,
-                                            V2_CQE_BYTE_28_SMAC_5_S);
-               wc->wc_flags |= IB_WC_WITH_SMAC;
+
                if (roce_get_bit(cqe->byte_28, V2_CQE_BYTE_28_VID_VLD_S)) {
                        wc->vlan_id = (u16)roce_get_field(cqe->byte_28,
                                                          V2_CQE_BYTE_28_VID_M,