mt76: mt7921: Fix out of order process by invalid event pkt
authorDeren Wu <deren.wu@mediatek.com>
Wed, 14 Jul 2021 15:50:52 +0000 (23:50 +0800)
committerFelix Fietkau <nbd@nbd.name>
Wed, 20 Oct 2021 08:36:29 +0000 (10:36 +0200)
The acceptable event report should inlcude original CMD-ID. Otherwise,
drop unexpected result from fw.

Fixes: 1c099ab44727c ("mt76: mt7921: add MCU support")
Signed-off-by: Jimmy Hu <Jimmy.Hu@mediatek.com>
Signed-off-by: Deren Wu <deren.wu@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c

index c621ddd..8d3cf4f 100644 (file)
@@ -157,6 +157,7 @@ mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd,
                          struct sk_buff *skb, int seq)
 {
        struct mt7921_mcu_rxd *rxd;
+       int mcu_cmd = cmd & MCU_CMD_MASK;
        int ret = 0;
 
        if (!skb) {
@@ -194,6 +195,9 @@ mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd,
                skb_pull(skb, sizeof(*rxd));
                event = (struct mt7921_mcu_uni_event *)skb->data;
                ret = le32_to_cpu(event->status);
+               /* skip invalid event */
+               if (mcu_cmd != event->cid)
+                       ret = -EAGAIN;
                break;
        }
        case MCU_CMD_REG_READ: {