iio: magnetometer: yas530: Change data type of hard_offsets to signed
authorJakob Hauser <jahau@rocketmail.com>
Fri, 12 Aug 2022 21:54:06 +0000 (23:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:35:03 +0000 (12:35 +0200)
[ Upstream commit e137fafc8985cf152a4bb6f18ae83ebb06816df1 ]

The "hard_offsets" are currently unsigned u8 but they should be signed as they
can get negative. They are signed in function yas5xx_meaure_offsets() and in the
Yamaha drivers [1][2].

[1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156
[2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91

Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530")
Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/40f052bf6491457d0c5c0ed4c3534dc6fa251c3c.1660337264.git.jahau@rocketmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/magnetometer/yamaha-yas530.c

index b2bc637..40192aa 100644 (file)
@@ -132,7 +132,7 @@ struct yas5xx {
        unsigned int version;
        char name[16];
        struct yas5xx_calibration calibration;
-       u8 hard_offsets[3];
+       s8 hard_offsets[3];
        struct iio_mount_matrix orientation;
        struct regmap *map;
        struct regulator_bulk_data regs[2];