afs: Fix possible assert with callbacks from yfs servers
authorMarc Dionne <marc.dionne@auristor.com>
Thu, 21 Nov 2019 15:26:15 +0000 (15:26 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 22 Nov 2019 22:19:26 +0000 (14:19 -0800)
Servers sending callback breaks to the YFS_CM_SERVICE service may
send up to YFSCBMAX (1024) fids in a single RPC.  Anything over
AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger.

Remove the assert, as the count has already been checked against
the appropriate max values in afs_deliver_cb_callback and
afs_deliver_yfs_cb_callback.

Fixes: 35dbfba3111a ("afs: Implement the YFS cache manager service")
Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/callback.c

index 6cdd704..2dca8df 100644 (file)
@@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count,
        _enter("%p,%zu,", server, count);
 
        ASSERT(server != NULL);
-       ASSERTCMP(count, <=, AFSCBMAX);
 
        /* TODO: Sort the callback break list by volume ID */