projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
48bc039
)
iio: dac: ad5592r: Fix the missing return value.
author
Zizhuang Deng
<sunsetdzz@gmail.com>
Thu, 10 Mar 2022 12:54:50 +0000
(20:54 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 9 May 2022 07:14:28 +0000
(09:14 +0200)
commit
b55b38f7cc12da3b9ef36e7a3b7f8f96737df4d5
upstream.
The third call to `fwnode_property_read_u32` did not record
the return value, resulting in `channel_offstate` possibly
being assigned the wrong value.
Fixes:
56ca9db862bf
("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
Link:
https://lore.kernel.org/r/20220310125450.4164164-1-sunsetdzz@gmail.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/dac/ad5592r-base.c
patch
|
blob
|
history
diff --git
a/drivers/iio/dac/ad5592r-base.c
b/drivers/iio/dac/ad5592r-base.c
index
0405e92
..
9872644
100644
(file)
--- a/
drivers/iio/dac/ad5592r-base.c
+++ b/
drivers/iio/dac/ad5592r-base.c
@@
-523,7
+523,7
@@
static int ad5592r_alloc_channels(struct iio_dev *iio_dev)
if (!ret)
st->channel_modes[reg] = tmp;
- fwnode_property_read_u32(child, "adi,off-state", &tmp);
+
ret =
fwnode_property_read_u32(child, "adi,off-state", &tmp);
if (!ret)
st->channel_offstate[reg] = tmp;
}