gst/avi/gstavidemux.c: Add comment in a fultile attempt to stop the copy-and-paste...

Original commit message from CVS:
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_event):
Add comment in a fultile attempt to stop the copy-and-paste
paradigm leading to duplication of bad code.

* gst/rtsp/rtsptransport.c: (rtsp_transport_parse):
Mime parameters have to be checked case insensitive

diff --git a/ChangeLog b/ChangeLog
index 746d196..1bbc4c4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2006-02-15  Wim Taymans  <wim@fluendo.com>
+
+       * gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_event):
+       Add comment in a fultile attempt to stop the copy-and-paste 
+       paradigm leading to duplication of bad code.
+
+       * gst/rtsp/rtsptransport.c: (rtsp_transport_parse):
+       Mime parameters have to be checked case insensitive
+
 2006-02-14  Tim-Philipp Müller  <tim at centricular dot net>
 
        * gst/matroska/matroska-demux.c: (gst_matroska_demux_sync_streams):

diff --git a/gst/avi/gstavidemux.c b/gst/avi/gstavidemux.c
index 8ca8a92..6d1bf41 100644 (file)
--- a/gst/avi/gstavidemux.c
+++ b/gst/avi/gstavidemux.c
@@ -455,6 +455,8 @@ gst_avi_demux_handle_src_event (GstPad * pad, GstEvent * event)
   switch (GST_EVENT_TYPE (event)) {
     case GST_EVENT_SEEK:
     {
+      /* FIXME, this seeking code is not correct, look at wavparse for 
+       * a better example */
       GstFormat format;
       GstSeekFlags flags;
       gdouble rate;

diff --git a/gst/rtsp/rtsptransport.c b/gst/rtsp/rtsptransport.c
index 3c208ee..3fdea27 100644 (file)
--- a/gst/rtsp/rtsptransport.c
+++ b/gst/rtsp/rtsptransport.c
@@ -80,7 +80,7 @@ parse_range (RTSPTransport * transport, gchar * str, RTSPRange * range)
 RTSPResult
 rtsp_transport_parse (gchar * str, RTSPTransport * transport)
 {
-  gchar **split;
+  gchar **split, *down;
   gint i;
 
   if (str == NULL || transport == NULL)
@@ -88,14 +88,17 @@ rtsp_transport_parse (gchar * str, RTSPTransport * transport)
 
   rtsp_transport_init (transport);
 
-  split = g_strsplit (str, ";", 0);
+  /* case insensitive */
+  down = g_ascii_strdown (str, -1);
+
+  split = g_strsplit (down, ";", 0);
   i = 0;
   while (split[i]) {
-    if (g_str_has_prefix (split[i], "RTP/AVP/UDP")) {
+    if (g_str_has_prefix (split[i], "rtp/avp/udp")) {
       transport->lower_transport = RTSP_LOWER_TRANS_UDP;
-    } else if (g_str_has_prefix (split[i], "RTP/AVP/TCP")) {
+    } else if (g_str_has_prefix (split[i], "rtp/avp/tcp")) {
       transport->lower_transport = RTSP_LOWER_TRANS_TCP;
-    } else if (g_str_has_prefix (split[i], "RTP/AVP")) {
+    } else if (g_str_has_prefix (split[i], "rtp/avp")) {
       transport->lower_transport = RTSP_LOWER_TRANS_UDP;
     } else if (g_str_has_prefix (split[i], "multicast")) {
       transport->multicast = TRUE;
@@ -130,6 +133,7 @@ rtsp_transport_parse (gchar * str, RTSPTransport * transport)
     i++;
   }
   g_strfreev (split);
+  g_free (down);
 
   return RTSP_OK;
 }