dma-mapping: remove dma_configure
authorChristoph Hellwig <hch@lst.de>
Fri, 24 Aug 2018 07:40:24 +0000 (09:40 +0200)
committerChristoph Hellwig <hch@lst.de>
Sat, 8 Sep 2018 09:19:20 +0000 (11:19 +0200)
There is no good reason for this indirection given that the method
always exists.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
drivers/base/dd.c
include/linux/dma-mapping.h
kernel/dma/mapping.c

index edfc9f0..65128cf 100644 (file)
@@ -480,9 +480,11 @@ re_probe:
        if (ret)
                goto pinctrl_bind_failed;
 
-       ret = dma_configure(dev);
-       if (ret)
-               goto dma_failed;
+       if (dev->bus->dma_configure) {
+               ret = dev->bus->dma_configure(dev);
+               if (ret)
+                       goto dma_failed;
+       }
 
        if (driver_sysfs_add(dev)) {
                printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n",
index 1db6a6b..1c6c7c0 100644 (file)
@@ -754,14 +754,8 @@ dma_mark_declared_memory_occupied(struct device *dev,
 #endif /* CONFIG_HAVE_GENERIC_DMA_COHERENT */
 
 #ifdef CONFIG_HAS_DMA
-int dma_configure(struct device *dev);
 void dma_deconfigure(struct device *dev);
 #else
-static inline int dma_configure(struct device *dev)
-{
-       return 0;
-}
-
 static inline void dma_deconfigure(struct device *dev) {}
 #endif
 
index d2a92dd..25607ce 100644 (file)
@@ -328,16 +328,6 @@ void dma_common_free_remap(void *cpu_addr, size_t size, unsigned long vm_flags)
 }
 #endif
 
-/*
- * enables DMA API use for a device
- */
-int dma_configure(struct device *dev)
-{
-       if (dev->bus->dma_configure)
-               return dev->bus->dma_configure(dev);
-       return 0;
-}
-
 void dma_deconfigure(struct device *dev)
 {
        of_dma_deconfigure(dev);