iwlwifi: dbg_ini: maintain buffer allocations from trans instead of TLVs buffer

Maintain DRAM debug buffer status in trans instead of keeping it as
part of the TLVs buffer to avoid allocating extra space for it.
Needed for future changes.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h b/drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h
index aaf3974..e02e289 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h
+++ b/drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h
@@ -439,6 +439,7 @@ enum iwl_fw_ini_apply_point {
  * @IWL_FW_INI_ALLOCATION_ID_SDFX: for SDFX module
  * @IWL_FW_INI_ALLOCATION_ID_FW_DUMP: used for crash and runtime dumps
  * @IWL_FW_INI_ALLOCATION_ID_USER_DEFINED: for future user scenarios
+ * @IWL_FW_INI_ALLOCATION_NUM: number of allocation ids
 */
 enum iwl_fw_ini_allocation_id {
        IWL_FW_INI_ALLOCATION_INVALID,
@@ -448,6 +449,7 @@ enum iwl_fw_ini_allocation_id {
        IWL_FW_INI_ALLOCATION_ID_SDFX,
        IWL_FW_INI_ALLOCATION_ID_FW_DUMP,
        IWL_FW_INI_ALLOCATION_ID_USER_DEFINED,
+       IWL_FW_INI_ALLOCATION_NUM,
 }; /* FW_DEBUG_TLV_ALLOCATION_ID_E_VER_1 */
 
 /**

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index 40b867f..6d69ed1 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -2503,7 +2503,7 @@ iwl_fw_dbg_buffer_allocation(struct iwl_fw_runtime *fwrt, u32 size)
 }
 
 static void iwl_fw_dbg_buffer_apply(struct iwl_fw_runtime *fwrt,
-                                   struct iwl_fw_ini_allocation_data *alloc,
+                                   struct iwl_fw_ini_allocation_tlv *alloc,
                                    enum iwl_fw_ini_apply_point pnt)
 {
        struct iwl_trans *trans = fwrt->trans;
@@ -2518,7 +2518,14 @@ static void iwl_fw_dbg_buffer_apply(struct iwl_fw_runtime *fwrt,
                .len[0] = sizeof(ldbg_cmd),
        };
        int block_idx = trans->dbg.num_blocks;
-       u32 buf_location = le32_to_cpu(alloc->tlv.buffer_location);
+       u32 buf_location = le32_to_cpu(alloc->buffer_location);
+       u32 alloc_id = le32_to_cpu(alloc->allocation_id);
+
+       if (alloc_id <= IWL_FW_INI_ALLOCATION_INVALID ||
+           alloc_id >= IWL_FW_INI_ALLOCATION_NUM) {
+               IWL_ERR(fwrt, "WRT: Invalid allocation id %d\n", alloc_id);
+               return;
+       }
 
        if (fwrt->trans->dbg.ini_dest == IWL_FW_INI_LOCATION_INVALID)
                fwrt->trans->dbg.ini_dest = buf_location;
@@ -2543,12 +2550,11 @@ static void iwl_fw_dbg_buffer_apply(struct iwl_fw_runtime *fwrt,
        if (buf_location != IWL_FW_INI_LOCATION_DRAM_PATH)
                return;
 
-       if (!alloc->is_alloc) {
-               iwl_fw_dbg_buffer_allocation(fwrt,
-                                            le32_to_cpu(alloc->tlv.size));
+       if (!(BIT(alloc_id) & fwrt->trans->dbg.is_alloc)) {
+               iwl_fw_dbg_buffer_allocation(fwrt, le32_to_cpu(alloc->size));
                if (block_idx == trans->dbg.num_blocks)
                        return;
-               alloc->is_alloc = 1;
+               fwrt->trans->dbg.is_alloc |= BIT(alloc_id);
        }
 
        /* First block is assigned via registers / context info */
@@ -2561,9 +2567,9 @@ static void iwl_fw_dbg_buffer_apply(struct iwl_fw_runtime *fwrt,
        cmd->num_frags = cpu_to_le32(1);
        cmd->fragments[0].address =
                cpu_to_le64(trans->dbg.fw_mon[block_idx].physical);
-       cmd->fragments[0].size = alloc->tlv.size;
-       cmd->allocation_id = alloc->tlv.allocation_id;
-       cmd->buffer_location = alloc->tlv.buffer_location;
+       cmd->fragments[0].size = alloc->size;
+       cmd->allocation_id = alloc->allocation_id;
+       cmd->buffer_location = alloc->buffer_location;
 
        iwl_trans_send_cmd(trans, &hcmd);
 }
@@ -2788,20 +2794,15 @@ static void _iwl_fw_dbg_apply_point(struct iwl_fw_runtime *fwrt,
                case IWL_UCODE_TLV_TYPE_DEBUG_INFO:
                        iwl_fw_dbg_info_apply(fwrt, ini_tlv, ext, pnt);
                        break;
-               case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION: {
-                       struct iwl_fw_ini_allocation_data *buf_alloc = ini_tlv;
-
+               case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION:
                        if (pnt != IWL_FW_INI_APPLY_EARLY) {
                                IWL_ERR(fwrt,
                                        "WRT: ext=%d. Invalid apply point %d for buffer allocation\n",
                                        ext, pnt);
                                goto next;
                        }
-
                        iwl_fw_dbg_buffer_apply(fwrt, ini_tlv, pnt);
-                       iter += sizeof(buf_alloc->is_alloc);
                        break;
-               }
                case IWL_UCODE_TLV_TYPE_HCMD:
                        if (pnt < IWL_FW_INI_APPLY_AFTER_ALIVE) {
                                IWL_ERR(fwrt,

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/img.h b/drivers/net/wireless/intel/iwlwifi/fw/img.h
index 18ca5f1..039576d 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/img.h
+++ b/drivers/net/wireless/intel/iwlwifi/fw/img.h
@@ -228,15 +228,6 @@ struct iwl_fw_dbg {
 };
 
 /**
- * @tlv: the buffer allocation tlv
- * @is_alloc: indicates if the buffer was already allocated
- */
-struct iwl_fw_ini_allocation_data {
-       struct iwl_fw_ini_allocation_tlv tlv;
-       u32 is_alloc;
-} __packed;
-
-/**
  * struct iwl_fw_ini_active_triggers
  * @active: is this trigger active
  * @size: allocated memory size of the trigger

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index 240e48b..5948d76 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -85,14 +85,6 @@ void iwl_dbg_tlv_copy(struct iwl_trans *trans, struct iwl_ucode_tlv *tlv,
        else
                data = &trans->dbg.apply_points[apply_point];
 
-       /* add room for is_alloc field in &iwl_fw_ini_allocation_data struct */
-       if (le32_to_cpu(tlv->type) == IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION) {
-               struct iwl_fw_ini_allocation_data *buf_alloc =
-                       (void *)tlv->data;
-
-               offset_size += sizeof(buf_alloc->is_alloc);
-       }
-
        /*
         * Make sure we still have room to copy this TLV. Offset points to the
         * location the last copy ended.
@@ -145,16 +137,6 @@ void iwl_dbg_tlv_alloc(struct iwl_trans *trans, size_t len, const u8 *data,
                if (WARN_ON(apply >= IWL_FW_INI_APPLY_NUM))
                        continue;
 
-               /* add room for is_alloc field in &iwl_fw_ini_allocation_data
-                * struct
-                */
-               if (tlv_type == IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION) {
-                       struct iwl_fw_ini_allocation_data *buf_alloc =
-                               (void *)tlv->data;
-
-                       size[apply] += sizeof(buf_alloc->is_alloc);
-               }
-
                size[apply] += sizeof(*tlv) + tlv_len;
        }
 

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
index fce0112..0fa4b10 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
@@ -695,6 +695,7 @@ struct iwl_self_init_dram {
  * @ini_valid: indicates if debug ini mode is on
  * @num_blocks: number of blocks in fw_mon
  * @fw_mon: address of the buffers for firmware monitor
+ * @is_alloc: bit i is set if buffer i was allocated
  * @hw_error: equals true if hw error interrupt was received from the FW
  * @ini_dest: debug monitor destination uses &enum iwl_fw_ini_buffer_location
  */
@@ -717,7 +718,8 @@ struct iwl_trans_debug {
        struct iwl_apply_point_data apply_points_ext[IWL_FW_INI_APPLY_NUM];
 
        int num_blocks;
-       struct iwl_dram_data fw_mon[IWL_FW_INI_APPLY_NUM];
+       struct iwl_dram_data fw_mon[IWL_FW_INI_ALLOCATION_NUM];
+       u32 is_alloc;
 
        bool hw_error;
        enum iwl_fw_ini_buffer_location ini_dest;