can: bxcan: Remove unnecessary print function dev_err()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Sat, 6 May 2023 08:07:25 +0000 (16:07 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 15 May 2023 20:53:49 +0000 (22:53 +0200)
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

./drivers/net/can/bxcan.c:970:2-9: line 970 is redundant because platform_get_irq() already prints an error.
./drivers/net/can/bxcan.c:964:2-9: line 964 is redundant because platform_get_irq() already prints an error.
./drivers/net/can/bxcan.c:958:2-9: line 958 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4878
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/all/20230506080725.68401-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/bxcan.c

index e26ccd4..7b285ee 100644 (file)
@@ -954,22 +954,16 @@ static int bxcan_probe(struct platform_device *pdev)
        }
 
        rx_irq = platform_get_irq_byname(pdev, "rx0");
-       if (rx_irq < 0) {
-               dev_err(dev, "failed to get rx0 irq\n");
+       if (rx_irq < 0)
                return rx_irq;
-       }
 
        tx_irq = platform_get_irq_byname(pdev, "tx");
-       if (tx_irq < 0) {
-               dev_err(dev, "failed to get tx irq\n");
+       if (tx_irq < 0)
                return tx_irq;
-       }
 
        sce_irq = platform_get_irq_byname(pdev, "sce");
-       if (sce_irq < 0) {
-               dev_err(dev, "failed to get sce irq\n");
+       if (sce_irq < 0)
                return sce_irq;
-       }
 
        ndev = alloc_candev(sizeof(struct bxcan_priv), BXCAN_TX_MB_NUM);
        if (!ndev) {