media: v4l: cadence: Handle errors of clk_prepare_enable()

Handle errors of clk_prepare_enable() in csi2rx_get_resources().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
index c68a3ea..f2b4ddd 100644 (file)
--- a/drivers/media/platform/cadence/cdns-csi2rx.c
+++ b/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -282,6 +282,7 @@ static int csi2rx_get_resources(struct csi2rx_priv *csi2rx,
        struct resource *res;
        unsigned char i;
        u32 dev_cfg;
+       int ret;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        csi2rx->base = devm_ioremap_resource(&pdev->dev, res);
@@ -315,7 +316,12 @@ static int csi2rx_get_resources(struct csi2rx_priv *csi2rx,
                return -EINVAL;
        }
 
-       clk_prepare_enable(csi2rx->p_clk);
+       ret = clk_prepare_enable(csi2rx->p_clk);
+       if (ret) {
+               dev_err(&pdev->dev, "Couldn't prepare and enable P clock\n");
+               return ret;
+       }
+
        dev_cfg = readl(csi2rx->base + CSI2RX_DEVICE_CFG_REG);
        clk_disable_unprepare(csi2rx->p_clk);