crypto: sun8i-ce - Fix PM reference leak in sun8i_ce_probe()
authorShixin Liu <liushixin2@huawei.com>
Thu, 8 Apr 2021 07:18:33 +0000 (15:18 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 16 Apr 2021 11:16:33 +0000 (21:16 +1000)
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c

index 158422f..00194d1 100644 (file)
@@ -932,7 +932,7 @@ static int sun8i_ce_probe(struct platform_device *pdev)
        if (err)
                goto error_alg;
 
-       err = pm_runtime_get_sync(ce->dev);
+       err = pm_runtime_resume_and_get(ce->dev);
        if (err < 0)
                goto error_alg;