configure.ac (GST_CFLAGS): GCC strikes back!!! Let the build breakage ensue!!!

Original commit message from CVS:
2005-06-29  Andy Wingo  <wingo@pobox.com>

* configure.ac (GST_CFLAGS): GCC strikes back!!! Let the build
breakage ensue!!!

* gst/rtsp/gstrtspsrc.c (gst_rtspsrc_loop, gst_rtspsrc_open):
Signedness, unused var fixes.
(gst_rtspsrc_close): Unused?

* gst/realmedia/rmdemux.c (re_hexdump_bytes): Unused.

* gst/law/mulaw-encode.c (gst_mulawenc_chain): Signeness fix.

* gst/law/alaw-encode.c (alawenc_getcaps): Remove unneeded
declarations. Typo (probably crasher) fix.

* gst/law/mulaw-encode.c (mulawdec_getcaps):
* gst/law/mulaw-encode.c (mulawenc_getcaps):
* gst/law/alaw-decode.c (alawdec_getcaps): Same crasher fix.

* gst/goom/gstgoom.c (gst_goom_init): Hook up the event function.

* gst/effectv/gstwarp.c (gst_warptv_setup): Signedness fix.

* gst/effectv/gstdice.c (gst_dicetv_draw): Um, deferencing
uninitialized pointer not good.

* gst/videofilter/gstvideoexample.c (plugin_init):
* gst/videofilter/Makefile.am (libgstvideoexample_la_LIBADD): Link
to libgstvideofilter instead of gst_library_load.

* gst/alpha/gstalpha.c (gst_alpha_chroma_key_i420)
(gst_alpha_chroma_key_ayuv): Signedness fixen.

diff --git a/ChangeLog b/ChangeLog
index 85aad67126043b76cf36dc5a3093dbd899e1bf4a..15b4db478c609e4e2483be358535897e38b3c381 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,37 @@
+2005-06-29  Andy Wingo  <wingo@pobox.com>
+
+       * configure.ac (GST_CFLAGS): GCC strikes back!!! Let the build
+       breakage ensue!!!
+
+       * gst/rtsp/gstrtspsrc.c (gst_rtspsrc_loop, gst_rtspsrc_open):
+       Signedness, unused var fixes.
+       (gst_rtspsrc_close): Unused?
+
+       * gst/realmedia/rmdemux.c (re_hexdump_bytes): Unused.
+
+       * gst/law/mulaw-encode.c (gst_mulawenc_chain): Signeness fix.
+
+       * gst/law/alaw-encode.c (alawenc_getcaps): Remove unneeded
+       declarations. Typo (probably crasher) fix.
+       
+       * gst/law/mulaw-encode.c (mulawdec_getcaps): 
+       * gst/law/mulaw-encode.c (mulawenc_getcaps): 
+       * gst/law/alaw-decode.c (alawdec_getcaps): Same crasher fix.
+
+       * gst/goom/gstgoom.c (gst_goom_init): Hook up the event function.
+
+       * gst/effectv/gstwarp.c (gst_warptv_setup): Signedness fix.
+
+       * gst/effectv/gstdice.c (gst_dicetv_draw): Um, deferencing
+       uninitialized pointer not good.
+
+       * gst/videofilter/gstvideoexample.c (plugin_init): 
+       * gst/videofilter/Makefile.am (libgstvideoexample_la_LIBADD): Link
+       to libgstvideofilter instead of gst_library_load.
+
+       * gst/alpha/gstalpha.c (gst_alpha_chroma_key_i420) 
+       (gst_alpha_chroma_key_ayuv): Signedness fixen.
+
 2005-06-29  Wim Taymans  <wim@fluendo.com>
 
        * gst/rtsp/gstrtspsrc.c: (gst_rtsp_proto_get_type),

diff --git a/configure.ac b/configure.ac
index 3b100287e580a2913f59ad59ea97f206ea31e3e2..6864b295723f1e1446eef481798bcbde4dd3ed60 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -439,6 +439,8 @@ GST_CHECK_FEATURE(ESD, [esound plug-ins], esdsink, [
   ])
 ])
 
+GST_CFLAGS="$GST_CFLAGS $GST_ERROR"
+
 AC_SUBST(GST_LIBS)
 AC_SUBST(GST_CFLAGS)
 

diff --git a/ext/mad/gstmad.c b/ext/mad/gstmad.c
index f6d09f2271525d651f48511f3709e6b11c677145..3dc345cbf10ed916934ea0ffb8073d6c6ce7e0a7 100644 (file)
--- a/ext/mad/gstmad.c
+++ b/ext/mad/gstmad.c
@@ -970,6 +970,7 @@ static gboolean
 gst_mad_sink_event (GstPad * pad, GstEvent * event)
 {
   GstMad *mad = GST_MAD (GST_PAD_PARENT (pad));
+  gint64 total;
 
   GST_DEBUG ("handling event %d", GST_EVENT_TYPE (event));
   switch (GST_EVENT_TYPE (event)) {
@@ -1013,10 +1014,11 @@ gst_mad_sink_event (GstPad * pad, GstEvent * event)
            * that this doesn't happen anywhere so far). */
           format = GST_FORMAT_DEFAULT;
           if (!gst_mad_convert_src (mad->srcpad,
-                  GST_FORMAT_TIME, time, &format, &mad->total_samples)) {
+                  GST_FORMAT_TIME, time, &format, &total)) {
             GST_DEBUG ("Failed to convert time to total_samples");
             continue;
           }
+          mad->total_samples = total;
 
           if (GST_PAD_IS_USABLE (mad->srcpad)) {
             discont = gst_event_new_discontinuous (FALSE, GST_FORMAT_TIME,
@@ -1274,7 +1276,7 @@ static GstFlowReturn
 gst_mad_chain (GstPad * pad, GstBuffer * buffer)
 {
   GstMad *mad;
-  gchar *data;
+  guchar *data;
   glong size;
   gboolean new_pts = FALSE;
   GstClockTime timestamp;
@@ -1491,9 +1493,11 @@ gst_mad_chain (GstPad * pad, GstBuffer * buffer)
         /* if we have a pending timestamp, we can use it now to calculate the sample offset */
         if (GST_CLOCK_TIME_IS_VALID (mad->last_ts)) {
           GstFormat format = GST_FORMAT_DEFAULT;
+          gint64 total;
 
           gst_pad_query_convert (mad->srcpad, GST_FORMAT_TIME, mad->last_ts,
-              &format, &mad->total_samples);
+              &format, &total);
+          mad->total_samples = total;
           mad->last_ts = GST_CLOCK_TIME_NONE;
         }
         time_offset = mad->total_samples * GST_SECOND / mad->rate;

diff --git a/gst/realmedia/rmdemux.c b/gst/realmedia/rmdemux.c
index 1cc8befd778fab30c5e771e8b7fb1c3f5c93ddbc..5102b3bf2b4104672663859146f6728ac36622b7 100644 (file)
--- a/gst/realmedia/rmdemux.c
+++ b/gst/realmedia/rmdemux.c
@@ -688,7 +688,7 @@ gst_rmdemux_add_stream (GstRMDemux * rmdemux, GstRMDemuxStream * stream)
   }
 }
 
-static void
+G_GNUC_UNUSED static void
 re_hexdump_bytes (guint8 * ptr, int len, int offset)
 {
   guint8 *end = ptr + len;