RDMA/efa: Fix setting of wrong bit in get/set_feature commands

When using a control buffer the ctrl_data bit should be set in order to
indicate the control buffer address is valid, not ctrl_data_indirect
which is used when the control buffer itself is indirect.

Fixes: e9c6c5373088 ("RDMA/efa: Add common command handlers")
Link: https://lore.kernel.org/r/20200512152204.93091-2-galpress@amazon.com
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.c b/drivers/infiniband/hw/efa/efa_com_cmd.c
index eea5574..69f842c 100644 (file)
--- a/drivers/infiniband/hw/efa/efa_com_cmd.c
+++ b/drivers/infiniband/hw/efa/efa_com_cmd.c
@@ -388,7 +388,7 @@ static int efa_com_get_feature_ex(struct efa_com_dev *edev,
 
        if (control_buff_size)
                EFA_SET(&get_cmd.aq_common_descriptor.flags,
-                       EFA_ADMIN_AQ_COMMON_DESC_CTRL_DATA_INDIRECT, 1);
+                       EFA_ADMIN_AQ_COMMON_DESC_CTRL_DATA, 1);
 
        efa_com_set_dma_addr(control_buf_dma_addr,
                             &get_cmd.control_buffer.address.mem_addr_high,
@@ -540,7 +540,7 @@ static int efa_com_set_feature_ex(struct efa_com_dev *edev,
        if (control_buff_size) {
                set_cmd->aq_common_descriptor.flags = 0;
                EFA_SET(&set_cmd->aq_common_descriptor.flags,
-                       EFA_ADMIN_AQ_COMMON_DESC_CTRL_DATA_INDIRECT, 1);
+                       EFA_ADMIN_AQ_COMMON_DESC_CTRL_DATA, 1);
                efa_com_set_dma_addr(control_buf_dma_addr,
                                     &set_cmd->control_buffer.address.mem_addr_high,
                                     &set_cmd->control_buffer.address.mem_addr_low);