media: ite-cir: carrier and duty cycle can be set via ioctl
authorSean Young <sean@mess.org>
Sat, 20 Feb 2021 12:41:37 +0000 (13:41 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:59:41 +0000 (11:59 +0100)
The lirc ioctls should be used for this, not module parameters.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/rc/ite-cir.c

index 14b551f..1cf060b 100644 (file)
 
 /* module parameters */
 
-/* low limit for RX carrier freq, Hz, 0 for no RX demodulation */
-static int rx_low_carrier_freq;
-module_param(rx_low_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(rx_low_carrier_freq, "Override low RX carrier frequency, Hz, 0 for no RX demodulation");
-
-/* high limit for RX carrier freq, Hz, 0 for no RX demodulation */
-static int rx_high_carrier_freq;
-module_param(rx_high_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(rx_high_carrier_freq, "Override high RX carrier frequency, Hz, 0 for no RX demodulation");
-
-/* override tx carrier frequency */
-static int tx_carrier_freq;
-module_param(tx_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(tx_carrier_freq, "Override TX carrier frequency, Hz");
-
-/* override tx duty cycle */
-static int tx_duty_cycle;
-module_param(tx_duty_cycle, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(tx_duty_cycle, "Override TX duty cycle, 1-100");
-
 /* override default sample period */
 static long sample_period;
 module_param(sample_period, long, S_IRUGO | S_IWUSR);
@@ -1409,18 +1389,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
        if (sample_period > 0)
                itdev->params.sample_period = sample_period;
 
-       if (tx_carrier_freq > 0)
-               itdev->params.tx_carrier_freq = tx_carrier_freq;
-
-       if (tx_duty_cycle > 0 && tx_duty_cycle <= 100)
-               itdev->params.tx_duty_cycle = tx_duty_cycle;
-
-       if (rx_low_carrier_freq > 0)
-               itdev->params.rx_low_carrier_freq = rx_low_carrier_freq;
-
-       if (rx_high_carrier_freq > 0)
-               itdev->params.rx_high_carrier_freq = rx_high_carrier_freq;
-
        /* set up hardware initial state */
        itdev->params.init_hardware(itdev);