[media] m5mols: potential uninitialized variable
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 15 Mar 2016 07:07:10 +0000 (04:07 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 20:10:59 +0000 (17:10 -0300)
Smatch complains that there are some paths where "status" isn't
initialized.  The code does assume that m5mols_read_u8() can fail so it
seems as if Smatch is correct.

Let's initialize it to REG_ISO_AUTO which is zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/m5mols/m5mols_controls.c

index a60931e..c2218c0 100644 (file)
@@ -405,7 +405,7 @@ static int m5mols_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
        struct v4l2_subdev *sd = to_sd(ctrl);
        struct m5mols_info *info = to_m5mols(sd);
        int ret = 0;
-       u8 status;
+       u8 status = REG_ISO_AUTO;
 
        v4l2_dbg(1, m5mols_debug, sd, "%s: ctrl: %s (%d)\n",
                 __func__, ctrl->name, info->isp_ready);