cpufreq: kirkwood: fix coccicheck warnings
authorSilviu-Mihai Popescu <silviupopescu1990@gmail.com>
Fri, 22 Mar 2013 00:10:22 +0000 (00:10 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 31 Mar 2013 23:11:35 +0000 (01:11 +0200)
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/kirkwood-cpufreq.c

index 0e83e3c..6052476 100644 (file)
@@ -175,11 +175,9 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
                dev_err(&pdev->dev, "Cannot get memory resource\n");
                return -ENODEV;
        }
-       priv.base = devm_request_and_ioremap(&pdev->dev, res);
-       if (!priv.base) {
-               dev_err(&pdev->dev, "Cannot ioremap\n");
-               return -EADDRNOTAVAIL;
-       }
+       priv.base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(priv.base))
+               return PTR_ERR(priv.base);
 
        np = of_find_node_by_path("/cpus/cpu@0");
        if (!np)