e_keyrouter: Remove useless return value from setter 20/317820/1
authorTaeHyeon Jeong <thyeon.jeong@samsung.com>
Mon, 6 Jan 2025 06:58:22 +0000 (15:58 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Wed, 8 Jan 2025 08:28:34 +0000 (17:28 +0900)
- Change  setter's return type to void

Change-Id: I4abbff11b9e98f12816d06dcd233e027b63a0f65

src/bin/inputmgr/e_keyrouter_hardkeys.c
src/bin/inputmgr/e_keyrouter_hardkeys_intern.h

index 97b5ae434b66e54a1dcd6df81ebe99fbbf62e7cb..31978108256ee3483570a1cc370af8cbf7c70d60 100644 (file)
@@ -222,11 +222,11 @@ e_keyrouter_hardkeys_repeat_get(E_Keyrouter_Grabbed_Key *hardkeys,
    return hardkeys[keycode].repeat;
 }
 
-EINTERN Eina_Bool
+EINTERN void
 e_keyrouter_hardkeys_list_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode,
         uint32_t mode, Eina_List *list)
 {
-   EINA_SAFETY_ON_NULL_RETURN_VAL(hardkeys, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_RETURN(hardkeys);
 
    switch(mode)
      {
@@ -250,24 +250,19 @@ e_keyrouter_hardkeys_list_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycod
          break;
       default:
          WRN("Unknown keycode(%d) and grab mode(%d)", keycode, mode);
-         return EINA_FALSE;
      }
-
-   return EINA_TRUE;
 }
 
-EINTERN Eina_Bool
+EINTERN void
 e_keyrouter_hardkeys_keycode_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode,
         char *keyname, Eina_Bool no_privcheck, Eina_Bool repeat)
 {
-   EINA_SAFETY_ON_NULL_RETURN_VAL(hardkeys, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_RETURN(hardkeys);
 
    hardkeys[keycode].keycode = keycode;
    hardkeys[keycode].keyname = keyname;
    hardkeys[keycode].no_privcheck = no_privcheck;
    hardkeys[keycode].repeat = repeat;
-
-   return EINA_TRUE;
 }
 
 EINTERN Eina_Bool
index d4856b86a24bd4402e81a968f4bac0bfd666e822..59b0de84fd2449420cca7b162a61b50999973c32 100644 (file)
@@ -18,8 +18,8 @@ EINTERN char       *e_keyrouter_hardkeys_keyname_get(E_Keyrouter_Grabbed_Key *ha
 EINTERN Eina_Bool  e_keyrouter_hardkeys_no_privcheck_get(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode);
 EINTERN Eina_Bool  e_keyrouter_hardkeys_repeat_get(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode);
 
-EINTERN Eina_Bool  e_keyrouter_hardkeys_list_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, uint32_t mode, Eina_List *list);
-EINTERN Eina_Bool  e_keyrouter_hardkeys_keycode_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, char *keyname, Eina_Bool no_privcheck, Eina_Bool repeat);
+EINTERN void      e_keyrouter_hardkeys_list_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, uint32_t mode, Eina_List *list);
+EINTERN void       e_keyrouter_hardkeys_keycode_set(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, char *keyname, Eina_Bool no_privcheck, Eina_Bool repeat);
 
 EINTERN Eina_Bool e_keyrouter_hardkeys_client_available(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, struct wl_client *client, uint32_t mode);
 EINTERN Eina_Bool e_keyrouter_hardkeys_surface_available(E_Keyrouter_Grabbed_Key *hardkeys, uint32_t keycode, struct wl_resource *surface, uint32_t mode);