[mediacontroller] Check for errors added.

+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.

+ Added return after error occured in AddPlaybackInfoChangeList().

[Verification] All tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4

diff --git a/src/mediacontroller/mediacontroller_api.js b/src/mediacontroller/mediacontroller_api.js
index 71bfaf6..050802c 100755 (executable)
--- a/src/mediacontroller/mediacontroller_api.js
+++ b/src/mediacontroller/mediacontroller_api.js
@@ -3287,6 +3287,9 @@ MediaControllerServerInfo.prototype.sendCommand = function(
 
     var replyListenerId = ReplyCommandListener.addListener(callback);
     var result = native_.callSync('MediaControllerServerInfo_sendCommand', nativeData);
+    if (native_.isFailure(result)) {
+      throw native_.getErrorObject(result);
+    }
 
     ReplyCommandListener.requestIdToListenerId[replyListenerId] = result.requestId;
 };

diff --git a/src/mediacontroller/mediacontroller_instance.cc b/src/mediacontroller/mediacontroller_instance.cc
index 4add498..268aa28 100644 (file)
--- a/src/mediacontroller/mediacontroller_instance.cc
+++ b/src/mediacontroller/mediacontroller_instance.cc
@@ -1415,6 +1415,7 @@ void MediaControllerInstance::MediaControllerServerInfoAddPlaybackInfoChangeList
   auto result = client_->SetPlaybackInfoListener(callback);
   if (!result) {
     LogAndReportError(result, &out);
+    return;
   }
 
   ReportSuccess(out);