projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0b325d9
)
irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions
author
Miaoqian Lin
<linmq006@gmail.com>
Wed, 1 Jun 2022 08:09:29 +0000
(12:09 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 22 Jun 2022 12:22:02 +0000
(14:22 +0200)
[ Upstream commit
fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b
]
of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes:
e3825ba1af3a
("irqchip/gic-v3: Add support for partitioned PPIs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link:
https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-gic-v3.c
patch
|
blob
|
history
diff --git
a/drivers/irqchip/irq-gic-v3.c
b/drivers/irqchip/irq-gic-v3.c
index
867a45a
..
fd4fb1b
100644
(file)
--- a/
drivers/irqchip/irq-gic-v3.c
+++ b/
drivers/irqchip/irq-gic-v3.c
@@
-1905,12
+1905,15
@@
static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
continue;
cpu = of_cpu_node_to_id(cpu_node);
- if (WARN_ON(cpu < 0))
+ if (WARN_ON(cpu < 0)) {
+ of_node_put(cpu_node);
continue;
+ }
pr_cont("%pOF[%d] ", cpu_node, cpu);
cpumask_set_cpu(cpu, &part->mask);
+ of_node_put(cpu_node);
}
pr_cont("}\n");