staging: rtl8192e: Remove PHY_SetRFPowerState and rename StateToSet
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 24 Aug 2022 20:14:49 +0000 (22:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2022 15:16:22 +0000 (17:16 +0200)
Remove macro that replaces PHY_SetRFPowerState with
rtl92e_set_rf_power_state and rename StateToSet to avoid CamelCase
which is not accepted by checkpatch.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/ae69fd4a09900a395de40b7cfc4fd8af81e63e13.1661370978.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 7c9148e..7f2a24b 100644 (file)
@@ -83,7 +83,6 @@ void rtl92e_set_rf_off(struct net_device *dev);
 
 bool rtl92e_set_rf_power_state(struct net_device *dev,
                               enum rt_rf_power_state eRFPowerState);
-#define PHY_SetRFPowerState rtl92e_set_rf_power_state
 
 void rtl92e_scan_op_backup(struct net_device *dev, u8 Operation);
 
index 8462dd9..5ac4817 100644 (file)
@@ -132,7 +132,7 @@ void rtl92e_writew(struct net_device *dev, int x, u16 y)
  *  -----------------------------GENERAL FUNCTION-------------------------
  ****************************************************************************/
 bool rtl92e_set_rf_state(struct net_device *dev,
-                        enum rt_rf_power_state StateToSet,
+                        enum rt_rf_power_state state_to_set,
                         RT_RF_CHANGE_SOURCE ChangeSource)
 {
        struct r8192_priv *priv = rtllib_priv(dev);
@@ -168,7 +168,7 @@ bool rtl92e_set_rf_state(struct net_device *dev,
 
        rtState = priv->rtllib->eRFPowerState;
 
-       switch (StateToSet) {
+       switch (state_to_set) {
        case eRfOn:
                priv->rtllib->RfOffReason &= (~ChangeSource);
 
@@ -215,8 +215,8 @@ bool rtl92e_set_rf_state(struct net_device *dev,
        }
 
        if (bActionAllowed) {
-               PHY_SetRFPowerState(dev, StateToSet);
-               if (StateToSet == eRfOn) {
+               rtl92e_set_rf_power_state(dev, state_to_set);
+               if (state_to_set == eRfOn) {
                        if (bConnectBySSID && priv->blinked_ingpio) {
                                schedule_delayed_work(
                                         &ieee->associate_procedure_wq, 0);
index 8f254c3..1796c88 100644 (file)
@@ -598,6 +598,6 @@ bool rtl92e_enable_nic(struct net_device *dev);
 bool rtl92e_disable_nic(struct net_device *dev);
 
 bool rtl92e_set_rf_state(struct net_device *dev,
-                        enum rt_rf_power_state StateToSet,
+                        enum rt_rf_power_state state_to_set,
                         RT_RF_CHANGE_SOURCE ChangeSource);
 #endif