net/mlx5: Allocate enough space for the FDB sub-namespaces
authorDan Carpenter <dan.carpenter@oracle.com>
Sun, 21 Oct 2018 11:05:49 +0000 (14:05 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Oct 2018 02:46:34 +0000 (19:46 -0700)
FDB_MAX_CHAIN is three.  We wanted to allocate enough memory to hold four
structs but there are missing parentheses so we only allocate enough
memory for three structs and the first byte of the fourth one.

Fixes: 328edb499f99 ("net/mlx5: Split FDB fast path prio to multiple namespaces")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

index 67ba4c9..9d73eb9 100644 (file)
@@ -2470,7 +2470,7 @@ static int init_fdb_root_ns(struct mlx5_flow_steering *steering)
                return -ENOMEM;
 
        steering->fdb_sub_ns = kzalloc(sizeof(steering->fdb_sub_ns) *
-                                      FDB_MAX_CHAIN + 1, GFP_KERNEL);
+                                      (FDB_MAX_CHAIN + 1), GFP_KERNEL);
        if (!steering->fdb_sub_ns)
                return -ENOMEM;