staging: vt6655: Remove vif check from vnt_interrupt
authorMalcolm Priestley <tvboxspy@gmail.com>
Wed, 27 Mar 2019 18:45:26 +0000 (18:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Mar 2019 16:25:45 +0000 (17:25 +0100)
A check for vif is made in vnt_interrupt_work.

There is a small chance of leaving interrupt disabled while vif
is NULL and the work hasn't been scheduled.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c

index 83f1a1c..c6bb4aa 100644 (file)
@@ -1137,8 +1137,7 @@ static irqreturn_t vnt_interrupt(int irq,  void *arg)
 {
        struct vnt_private *priv = arg;
 
-       if (priv->vif)
-               schedule_work(&priv->interrupt_work);
+       schedule_work(&priv->interrupt_work);
 
        MACvIntDisable(priv->PortOffset);